[docs] Move custom theme to frame#26744
Merged
siriwatknp merged 2 commits intomui:nextfrom Jun 16, 2021
Merged
Conversation
Member
|
I believe the changes are leading us to the same mistake I did initially with #22112 (2-3 years ago). I patched the docs for values I didn't like in the default theme. I think that we should fully own the default theme: Either we say, 1. no Material Design this is not OK: #25522 (comment) and we change the default value of the theme. 2. Or we bit the bullet and follow them. In 1. a halfway solution would be to replace |
Member
Author
I think we can go with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #22112
I still want to keep
#222as background because I think thisis better than
So I move the color to frame instead. I don't think this will confuse the people because the body still contain default background color. @oliviertassinari what do you think?