Skip to content

[pickers] Migrate PickersPopper to emotion#26391

Merged
siriwatknp merged 4 commits intomui:nextfrom
siriwatknp:pickers-popper-emotion
May 21, 2021
Merged

[pickers] Migrate PickersPopper to emotion#26391
siriwatknp merged 4 commits intomui:nextfrom
siriwatknp:pickers-popper-emotion

Conversation

@siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented May 20, 2021 •
edited
Loading

This is an internal component, so no need sx or ClassKey

add type to mark styleProps as required for this StyledComponent when rendered.

const PickersPopperPaper = styled(
  Paper,
  {},
  { skipSx: true },
)<{ styleProps: Pick<MuiPopperProps, 'placement'> }>(({ styleProps }) => ({
  ...styling
}));

@siriwatknp siriwatknp added the scope: pickers Changes related to the date/time pickers. label May 20, 2021
@siriwatknp siriwatknp requested a review from mnajdova May 20, 2021 07:44
@mui-pr-bot
Copy link

mui-pr-bot commented May 20, 2021 •
edited
Loading

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against 1ebb8eb

@siriwatknp siriwatknp mentioned this pull request May 20, 2021
Closed
mnajdova
mnajdova reviewed May 20, 2021
View reviewed changes
mnajdova
mnajdova reviewed May 20, 2021
View reviewed changes
siriwatknp
siriwatknp commented May 20, 2021
View reviewed changes
packages/material-ui-lab/src/internal/pickers/PickersPopper.tsx
})}
onClick={onPaperClick}
onTouchStart={onPaperTouchStart}
styleProps={{ ...styleProps, placement }}
Copy link
Member Author

@siriwatknp siriwatknp May 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

placement is not from props.

@siriwatknp siriwatknp requested a review from mnajdova May 20, 2021 09:27
@siriwatknp siriwatknp merged commit 0efe477 into mui:next May 21, 2021
@siriwatknp siriwatknp deleted the pickers-popper-emotion branch May 21, 2021 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees

No one assigned

Labels

scope: pickers Changes related to the date/time pickers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siriwatknp @mui-pr-bot @mnajdova