[TimePicker] Migrate ClockPicker to emotion#26389
Conversation
|
Details of bundle changes (experimental) @material-ui/lab: parsed: +0.08% , gzip: -0.10% 😍 |
| refInstanceof: window.HTMLDivElement, | ||
| muiName: 'MuiClockPicker', | ||
| // cannot test reactTestRenderer because of required context | ||
| testRootOverrides: null, |
There was a problem hiding this comment.
This component does not have root slot.
test/utils/describeConformanceV5.js
Outdated
| } | ||
| }); | ||
|
|
||
| it("respect theme's styleOverrides specific slot", function test() { |
There was a problem hiding this comment.
add new test for specific slot. @mnajdova should it be another PR or this PR is fine?
There was a problem hiding this comment.
Let's handle this in a separate PR. We can disable this test for the component with Todo and handle it in a follow up. I wouldn't add this logic in the describeConformance as it is not a conformant thing :)
…ock-picker-emotion
We should not make Now that this is the last component from the migration to @emotion (good job for taking this to the finish line @siriwatknp), we can revisit the code debt that we left, by resolving the Todos. |
mnajdova
left a comment
There was a problem hiding this comment.
Last one done 🎉 great work @siriwatknp
Closes #24405 🎉