[pickers] Migrate TimePickerToolbar to emotion#26274
Merged
siriwatknp merged 6 commits intomui:nextfrom May 18, 2021
Merged
Conversation
…me-picker-toolbar-emotion
|
Details of bundle changes (experimental) @material-ui/lab: parsed: +0.16% , gzip: +0.16% |
Member
What is the indication that this is an internal component? Was it not exported? Looks like it had public name - |
siriwatknp
commented
May 13, 2021
…me-picker-toolbar-emotion
mnajdova
reviewed
May 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@eps1lon this component is an internal component but in theme augmentationoverrides.d.tsexposesMuiTimePickerToolbaras themable. Should I remove it from theme augmentation or convert this to public component?decide to remain as internal component and remove from
overrides.d.ts