Skip to content

[Autocomplete] Rename values of the reason argument#26172

Merged
m4theushw merged 1 commit intomui:nextfrom
m4theushw:rename-autocomplete-reason
May 7, 2021
Merged

[Autocomplete] Rename values of the reason argument#26172
m4theushw merged 1 commit intomui:nextfrom
m4theushw:rename-autocomplete-reason

Conversation

@m4theushw
Copy link
Collaborator

@m4theushw m4theushw commented May 6, 2021 •
edited by oliviertassinari
Loading

Breaking changes

  • [Autocomplete] Rename the values of the reason argument in onChange and onClose for consistency:

    1. create-option to createOption
    2. select-option to selectOption
    3. remove-option to removeOption

Part of #20012

@mui-pr-bot
Copy link

mui-pr-bot commented May 6, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 698391b

@oliviertassinari oliviertassinari added breaking change Introduces changes that are not backward compatible. scope: autocomplete Changes related to the autocomplete. This includes ComboBox. labels May 6, 2021
@github-actions github-actions bot mentioned this pull request May 6, 2021
Closed
@m4theushw m4theushw mentioned this pull request May 7, 2021
Closed
@oliviertassinari oliviertassinari mentioned this pull request May 7, 2021
Closed
2 tasks
@m4theushw m4theushw merged commit ac3506a into mui:next May 7, 2021
@m4theushw m4theushw deleted the rename-autocomplete-reason branch May 7, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

No one assigned

Labels

breaking change Introduces changes that are not backward compatible. scope: autocomplete Changes related to the autocomplete. This includes ComboBox.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@m4theushw @mui-pr-bot @oliviertassinari