[pickers] Migrate ClockNumber to emotion#26058
Merged
siriwatknp merged 15 commits intomui:nextfrom May 13, 2021
Merged
Conversation
Member
siriwatknp
commented
Apr 29, 2021
- I have followed (at least) the PR section of the contributing guide.
mnajdova
reviewed
Apr 29, 2021
Member
|
@siriwatknp let's try to merge some of the open PRs before opening new ones |
Member
Author
okay, noted. |
eps1lon
requested changes
Apr 30, 2021
Member
eps1lon
left a comment
There was a problem hiding this comment.
Let's resolve the existing ones first. The amount of boilerplate that is required for internal components is not ok.
Member
The component isn't strictly speaking internal. The class names are public. Proof: |
Member
The API is there yes. But I consider them at this point internal since there's not documentation. Once pickers are in a presentable shape we can talk about customization. But right now it's not a concern worth debating over. |
mnajdova
approved these changes
May 3, 2021
mnajdova
reviewed
May 11, 2021
…ock-number-emotion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.