Skip to content

[pickers] Migrate PickersDay to emotion#25995

Merged
siriwatknp merged 18 commits intomui:nextfrom
siriwatknp:pickers-day-emotion
May 11, 2021
Merged

[pickers] Migrate PickersDay to emotion#25995
siriwatknp merged 18 commits intomui:nextfrom
siriwatknp:pickers-day-emotion

Conversation

@siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Apr 27, 2021

One of #24405

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 27, 2021

Details of bundle changes (experimental)

@material-ui/lab: parsed: +0.30% , gzip: +0.22%

Generated by 🚫 dangerJS against 6cb9abc

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the original implementation logic. It should return different components not the same component with different props.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 28, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 28, 2021
@oliviertassinari oliviertassinari changed the title [Pickers] Migrate PickersDay to emotion [pickers] Migrate PickersDay to emotion Apr 28, 2021
@oliviertassinari oliviertassinari added the scope: pickers Changes related to the date/time pickers. label Apr 28, 2021
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 29, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 29, 2021
@siriwatknp siriwatknp requested review from eps1lon and mnajdova April 29, 2021 10:45
siriwatknp and others added 2 commits April 30, 2021 08:14
@siriwatknp siriwatknp merged commit 68ea9e5 into mui:next May 11, 2021
@siriwatknp siriwatknp deleted the pickers-day-emotion branch May 11, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: pickers Changes related to the date/time pickers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants