Skip to content

[TextField] Make the position prop required in InputAdornment#25891

Merged
m4theushw merged 2 commits intomui:nextfrom
m4theushw:inputAdornment
Apr 23, 2021
Merged

[TextField] Make the position prop required in InputAdornment#25891
m4theushw merged 2 commits intomui:nextfrom
m4theushw:inputAdornment

Conversation

@m4theushw
Copy link
Collaborator

Part of #20012

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 22, 2021

No bundle size changes

Generated by 🚫 dangerJS against 2024c4a

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 22, 2021

Did you find the context on why? I can't recall the motivation.

@oliviertassinari
Copy link
Member

Oh yes, I remember, it's because we don't use the context to infer the placement from the startAdornment or endAdornment prop. All the demo provide the prop anyway. It sounds good. It's not really a breaking change, more a cleanup. And in the future, we can consider using the context.

@m4theushw
Copy link
Collaborator Author

Actually, the prop is already required in the .d.ts file in v4. It was made optional in v5 here. I think we don't need to update the migration guide. Just adding an isRequired in v4 is fine.

@oliviertassinari oliviertassinari added the scope: text field Changes related to the text field. label Apr 22, 2021
@m4theushw m4theushw merged commit f389f2c into mui:next Apr 23, 2021
@m4theushw m4theushw deleted the inputAdornment branch April 23, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: text field Changes related to the text field.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants