Merged
Conversation
|
@material-ui/core: parsed: +0.34% , gzip: +0.22% |
This comment has been minimized.
This comment has been minimized.
oliviertassinari
approved these changes
Apr 18, 2021
Member
oliviertassinari
left a comment
There was a problem hiding this comment.
At a high level, it looks good, but I didn't dive deep into the review. Best to have Marija review it
siriwatknp
commented
Apr 18, 2021
mnajdova
reviewed
Apr 19, 2021
mnajdova
reviewed
Apr 21, 2021
Member
mnajdova
left a comment
There was a problem hiding this comment.
Good job, couple of things to be resolved before merging.
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
mnajdova
reviewed
Apr 23, 2021
mnajdova
approved these changes
Apr 23, 2021
Member
mnajdova
left a comment
There was a problem hiding this comment.
I just pushed one fix for the scrollButtons overrides, looks good otherwise 👍
Member
|
@material-ui/core => 100% migrated 🙏 |
Member
Looks like we both waited to see this too long now 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One chunk of #24405