Skip to content

[Timeline] Migrate TimelineContent to emotion#25781

Merged
mnajdova merged 18 commits intomui:nextfrom
siriwatknp:timeline-content-migration
Apr 16, 2021
Merged

[Timeline] Migrate TimelineContent to emotion#25781
mnajdova merged 18 commits intomui:nextfrom
siriwatknp:timeline-content-migration

Conversation

@siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Apr 15, 2021 •
edited by oliviertassinari
Loading

One of #24405

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 15, 2021 •
edited
Loading

Details of bundle changes

@material-ui/lab: parsed: +0.13% , gzip: +0.10%

Generated by 🚫 dangerJS against ecbd75b

mnajdova
mnajdova reviewed Apr 15, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review :)

@mnajdova mnajdova added the scope: timeline Changes related to the timeline. label Apr 15, 2021
@mnajdova mnajdova changed the title [TimelineContent] migrate to emotion [Timeline] Migrate TimelineContent to emotion Apr 15, 2021
siriwatknp and others added 6 commits April 15, 2021 23:53
@siriwatknp @mnajdova
Update packages/material-ui-lab/src/TimelineContent/TimelineContent.d.ts
5d71ad3 
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
@siriwatknp @mnajdova
Update packages/material-ui-lab/src/TimelineContent/TimelineContent.js
f05063f 
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
@siriwatknp @mnajdova
Update packages/material-ui-lab/src/TimelineContent/TimelineContent.js
71e3461 
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
@siriwatknp @mnajdova
Update packages/material-ui-lab/src/TimelineContent/TimelineContent.js
6f9bbf4 
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
@siriwatknp @mnajdova
Update test/utils/describeConformance.js
2195626 
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
@siriwatknp
add alignLeft & alignAlternate to classes
0bf8db8
mnajdova
mnajdova reviewed Apr 15, 2021
View reviewed changes
@oliviertassinari oliviertassinari mentioned this pull request Apr 15, 2021
Closed
oliviertassinari
oliviertassinari reviewed Apr 15, 2021
View reviewed changes
@siriwatknp
Copy link
Member Author

siriwatknp commented Apr 16, 2021 •
edited
Loading

@oliviertassinari @mnajdova I cannot find a way to fix this, need your helps. (works fine locally)

Trigger CI again fixed the error. 😊

image

mnajdova
mnajdova approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @siriwatknp 👍

@mnajdova mnajdova merged commit c9c69b5 into mui:next Apr 16, 2021
@vicasas vicasas mentioned this pull request Apr 17, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@mnajdova mnajdova mnajdova approved these changes

Assignees

No one assigned

Labels

scope: timeline Changes related to the timeline.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@siriwatknp @mui-pr-bot @oliviertassinari @mnajdova