[DatePicker] data-picker-inline Popover instead of Paper#2557
[DatePicker] data-picker-inline Popover instead of Paper#2557tyfoo wants to merge 1 commit intomui:masterfrom
Conversation
|
Could you add The Popover is not correctly positioned when opened. |
There was a problem hiding this comment.
Can you put the {...other} at the beginning? I think that it's better in general, you don't want specific properties to be overridden.
|
Only thing I can think of is that the ref won't exist on the first render, so if that happens to be the only render, then you're effectively passing null to the |
That's true. However, when the popover is opened and rerendered, the ref is valid, still the position is wrong. |
b6bc2b7 to
91cf8e1
Compare
|
@oliviertassinari I've moved In regards to I've noticed that |
|
you'll need it, as if the state is reset externally then open prop could be wrong. Specifically, the inline date picker should handle |
#2120 (comment)