Skip to content

[docs] Migrate Portal demos to emotion#25505

Merged
oliviertassinari merged 1 commit intomui:nextfrom
vicasas:feature/migrate-portal-demo-to-emotion
Mar 26, 2021
Merged

[docs] Migrate Portal demos to emotion#25505
oliviertassinari merged 1 commit intomui:nextfrom
vicasas:feature/migrate-portal-demo-to-emotion

Conversation

@vicasas
Copy link
Member

@vicasas vicasas commented Mar 25, 2021

Related to #16947

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 25, 2021

No bundle size changes

Generated by 🚫 dangerJS against d886032

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation. component: Portal labels Mar 25, 2021
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving a note for @mnajdova. This made me wonder if we should document

import Portal from '@material-ui/unstyled/Portal';

instead of

import Portal from '@material-ui/core/Portal';

or if we should add an ## Unstyled hero section in the page.

@mnajdova
Copy link
Member

mnajdova commented Apr 1, 2021

I'm leaving a note for @mnajdova. This made me wonder if we should document

import Portal from '@material-ui/unstyled/Portal';

instead of

import Portal from '@material-ui/core/Portal';

or if we should add an ## Unstyled hero section in the page.

For the sake of simplicity from developer's perspective, I think we should leave the import

import Portal from '@material-ui/core/Portal';

Developers shouldn't care about the specifics of whether this component has styles or not. If they want to use the unstyled version, they may change the import to the unstyled package. We anyway aim to have an unstyled version for all components. +1 for adding some kind of Unstyled tag or something similar in the docs that indicates that this is an unstyled component.

@oliviertassinari
Copy link
Member

In this case, I would propose we add an ## Unstyled section on these pages with a mention to

import Portal from '@material-ui/unstyled/Portal';

While the unstyled nature of the demos on the page suggests, it's not obvious that it's available in this package too.

@oliviertassinari oliviertassinari added scope: portal Changes related to the portal. and removed component: Portal labels Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: portal Changes related to the portal.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants