Skip to content

[docs] Migrate Icons demos to emotion#25412

Merged
oliviertassinari merged 12 commits intomui:nextfrom
vicasas:feature/migrate-icons-demo-to-emotion
Mar 24, 2021
Merged

[docs] Migrate Icons demos to emotion#25412
oliviertassinari merged 12 commits intomui:nextfrom
vicasas:feature/migrate-icons-demo-to-emotion

Conversation

@vicasas
Copy link
Member

@vicasas vicasas commented Mar 18, 2021

The following demos of the Icons component were migrated:

  • SvgMaterialIcons
  • SvgIconsColor
  • SvgIconsSize
  • CreateSvgIcon
  • FontAwesomeSvgIconDemo
  • Icons
  • FontAwesomeIcon
  • FontAwesomeIconSize
  • visuallyHidden

Related to #16947

@vicasas vicasas mentioned this pull request Mar 18, 2021
Closed
89 tasks
@mui-pr-bot
Copy link

mui-pr-bot commented Mar 18, 2021 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 5bf2abc

@github-actions github-actions bot mentioned this pull request Mar 18, 2021
Closed
@oliviertassinari oliviertassinari added the on hold There is a blocker, we need to wait. label Mar 18, 2021
oliviertassinari
oliviertassinari requested changes Mar 21, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't too far

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation. and removed on hold There is a blocker, we need to wait. labels Mar 21, 2021
@vicasas
Copy link
Member Author

vicasas commented Mar 22, 2021

i will check this later

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 24, 2021

The visual regression is expected, it will be solved once we can remove injectFirst from the emotion config provider. Basically, the font icon CSS file set a font-size property later on in the DOM head order.

@oliviertassinari oliviertassinari merged commit e87eac1 into mui:next Mar 24, 2021
@github-actions github-actions bot mentioned this pull request Mar 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

No one assigned

Labels

docs Improvements or additions to the documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vicasas @mui-pr-bot @oliviertassinari