Skip to content

[utils] Fix isMuiElement types#24936

Merged
oliviertassinari merged 1 commit intomui:nextfrom
oliviertassinari:fix-types-regression
Feb 14, 2021
Merged

[utils] Fix isMuiElement types#24936
oliviertassinari merged 1 commit intomui:nextfrom
oliviertassinari:fix-types-regression

Conversation

@oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Feb 14, 2021

It turns out that the types were wrong. Fix the regression reported in https://github.com/mui-org/material-ui/pull/24795/files#r575824679. I have used this as an opportunity to move the helper to TypeScript.

@oliviertassinari oliviertassinari added type: bug It doesn't behave as expected. typescript package: utils Specific to the utils package. labels Feb 14, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Feb 14, 2021

No bundle size changes

Generated by 🚫 dangerJS against c61fd7c

@oliviertassinari oliviertassinari merged commit 18e8168 into mui:next Feb 14, 2021
@oliviertassinari oliviertassinari deleted the fix-types-regression branch February 14, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: utils Specific to the utils package. type: bug It doesn't behave as expected. typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants