Skip to content

[Autocomplete] Migrate to emotion#24696

Merged
oliviertassinari merged 16 commits intomui:nextfrom
natac13:autocomplete-emotion
Feb 15, 2021
Merged

[Autocomplete] Migrate to emotion#24696
oliviertassinari merged 16 commits intomui:nextfrom
natac13:autocomplete-emotion

Conversation

@natac13
Copy link
Contributor

@natac13 natac13 commented Jan 29, 2021

#24405

Have some failing tests due to:

Using first-child instead of first-of-type. Says first-child not save in SSR. Just not sure how you would like this handled.

The other is to do with the icon classes test. hasPopupIcon and hasClearIcon

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 29, 2021

@material-ui/core: parsed: +0.61% , gzip: +0.47%
@material-ui/lab: parsed: +0.69% , gzip: +0.69%

Details of bundle changes

Generated by 🚫 dangerJS against 1cc9ddf

@oliviertassinari oliviertassinari added the scope: autocomplete Changes related to the autocomplete. This includes ComboBox. label Jan 29, 2021
@oliviertassinari oliviertassinari self-assigned this Feb 14, 2021
@oliviertassinari oliviertassinari merged commit a1e651f into mui:next Feb 15, 2021
@oliviertassinari
Copy link
Member

@natac13 A hard one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: autocomplete Changes related to the autocomplete. This includes ComboBox.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants