[Table] Migrate TableBody to emotion by natac13 · Pull Request #24658 · mui/material-ui

natac13 · 2021-01-27T17:09:55Z

I have followed (at least) the PR section of the contributing guide.

#24405

mui-pr-bot · 2021-01-27T17:12:11Z

@material-ui/core: parsed: +0.08% , gzip: +0.06%

Details of bundle changes

Generated by 🚫 dangerJS against 480c2f8

packages/material-ui/src/TableBody/TableBody.js

mnajdova · 2021-01-28T06:26:12Z

For fixing the error - https://app.circleci.com/pipelines/github/mui-org/material-ui/37282/workflows/f4054c2a-44af-4550-8ada-1e1c75514d81/jobs/220749

I believe we need to introduce a new option to the describeConformanceV5, so that we can wrap the element in <table /> and the structure would be correct. We can use something similar to the mount option, or introduce a callback of how to find the element, for example node.firstChild.firstChild and invoke the describeConformanceV5 with describeConformance(renderInTable(<TableBody />), ....).

natac13 · 2021-01-28T15:16:06Z

Alright I have taken a shot at getting conformanceV5 working with a wrapper function.
I do not think the way I have done this is the best and I am very open to suggestions.
I am still failing the theme variant props test.

mnajdova · 2021-01-28T15:24:55Z

Alright I have taken a shot at getting conformanceV5 working with a wrapper function.
I do not think the way I have done this is the best and I am very open to suggestions.
I am still failing the theme variant props test.

Did you try to introduce some render option, similar to how the mount is defined? I think that would require less changes in the tests themselves. If the option is not provided, we can default to the render we are using at this moment. cc @oliviertassinari for thoughts on this

natac13 · 2021-01-28T15:26:13Z

Oh I see what you mean.
Provide a render to wrap in table but use the normal render when not.
I'll make the changes

mnajdova · 2021-01-28T15:30:24Z

Oh I see what you mean.
Provide a render to wrap in table but use the normal render when not.
I'll make the changes

Exactlly, just watch out that the return result from render is a bit different, I suppose you would need to alter the container from the result object.

natac13 · 2021-01-28T15:50:14Z

Ok let me know what you think of 370b4c5

Maybe once we get this figured out I should wait till it gets merged to next, then rebase next for the TableCell PR?

mnajdova · 2021-01-28T16:03:19Z

Ok let me know what you think of 370b4c5

Maybe once we get this figured out I should wait till it gets merged to next, then rebase next for the TableCell PR?

Exactly what I had in mind, I would maybe just suggest renaming the param to render, but let's wait on @oliviertassinari or @eps1lon feedback before doing any other changes. Also would propose moving these changes in a separate PR

natac13 · 2021-01-28T16:04:51Z

Also would propose moving these changes in a separate PR

I was just wondering the same thing as I re-read my comment

Ill wait to hear the instructions.

Ill Start on a none table component until we get this merged into next

oliviertassinari · 2021-01-28T16:44:50Z

packages/material-ui/src/TableBody/TableBody.test.js

      return wrapper.find('table').childAt(0);
    },
-
+    wrapRender: (node) => {


Agree with Marija, render sounds better and more consistent with what Sebastian did with mount.

Suggested change

wrapRender: (node) => {

render: (node) => {

Am I still ok to use wrapRender in the conformance tests as the name would conflict with the normal render?

eps1lon · 2021-01-28T16:57:38Z

packages/material-ui/src/TableBody/TableBody.test.js

      return wrapper.find('table').childAt(0);
    },
-
+    wrapRender: (node) => {


Marking this for future follow-up: check-out something like render(node, { container: document.createElement('tabl') }) (need to check for connectedness and cleanup)

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

…ble (mui#24671)

…4650)

…ion (mui#24667)

natac13 · 2021-01-30T14:44:05Z

I suck at rebasing... Ill open a new PR

TableBody to emotion

32d3a0d

github-actions bot mentioned this pull request Jan 27, 2021

Update snapshots for pr/24658 eps1lon/mui-scripts-incubator#1783

Closed

oliviertassinari mentioned this pull request Jan 27, 2021

Migrate all components to emotion #24405

Closed

oliviertassinari added the scope: table Changes related to the table. label Jan 27, 2021

mnajdova reviewed Jan 28, 2021

View reviewed changes

packages/material-ui/src/TableBody/TableBody.js Outdated Show resolved Hide resolved

Update packages/material-ui/src/TableBody/TableBody.js

a46306e

mnajdova mentioned this pull request Jan 28, 2021

[Table] Migrate TableCell to emotion #24663

Merged

1 task

table test update attempt

e91474a

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jan 28, 2021

conformance update for wrapped table elements

370b4c5

remove unneeded interface TableBodyClasses

5a79990

oliviertassinari reviewed Jan 28, 2021

View reviewed changes

eps1lon reviewed Jan 28, 2021

View reviewed changes

change to render in conformanceV5

fd98d33

natac13 mentioned this pull request Jan 28, 2021

[test] Conformance to handle wrapped elements #24679

Merged

1 task

revert conformance waiting on mui#24679

253b4ab

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jan 28, 2021

natac13 and others added 4 commits January 28, 2021 12:42

revert conformance change

9d634c2

[CircularProgress] Migrate to emotion (mui#24622)

57486e0

[ImageList] Migrate ImageListItemBar to emotion (mui#24632)

1482605

[TextField] Migrate Input component to emotion (mui#24638)

b9700b4

natac13 and others added 22 commits January 30, 2021 09:41

[Tab] Migrate to emotion (mui#24651)

7974435

[docs] Clarifying the documentation about Chip behavior (mui#24645)

bc31712

[Table] Migrate to emotion (mui#24657)

81367ef

[List] Migrate ListItemAvatar to emotion (mui#24656)

5078260

[TextField] Migrate FormControl to emotion (mui#24659)

f7a9bc6

[Table] Migrate TableContainer to emotion (mui#24666)

6ee0cb0

[Tab] Migrate TabScrollButton to emotion (mui#24654)

1aace9a

[Card] Warn on raised + outlined (mui#24648)

3c4a3e0

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

[docs] Update Typography in migration guide (mui#24662)

14a5bad

[tests] Skip JSDOM in style related conformance tests (mui#24668)

576aea2

[TextField] Migrate FormHelperText to emotion (mui#24661)

c207c0c

[Dialog] Migrate DialogContent to emotion (mui#24670)

4694fa8

[styled-engine] Fix GlobalStyles not to throw when no theme is availa…

72ca81d

…ble (mui#24671)

[Pickers] Fix showTodayButton not returning the current time (mui#2…

e1d86ec

…4650)

[Typography] Add system props (mui#24496)

aeec19e

[examples] Update examples to use StyledEngineProvider (mui#24489)

e1397d0

[Paper] Improve warning on invalid combinations of variant and elevat…

558e27b

…ion (mui#24667)

[Chip] Migrate to emotion (mui#24649)

c425727

[docs] Add API documentation for *DatePicker components (mui#24655)

c433cd5

[ToggleButton] Migrate to emotion (mui#24674)

756fd71

[Step] Migrate to emotion (mui#24678)

d81cc89

[test] Conformance to handle wrapped elements (mui#24679)

480c2f8

natac13 closed this Jan 30, 2021

Uh oh!

Conversation

natac13 commented Jan 27, 2021

Uh oh!

mui-pr-bot commented Jan 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mnajdova commented Jan 28, 2021

Uh oh!

natac13 commented Jan 28, 2021

Uh oh!

mnajdova commented Jan 28, 2021

Uh oh!

natac13 commented Jan 28, 2021

Uh oh!

mnajdova commented Jan 28, 2021

Uh oh!

natac13 commented Jan 28, 2021

Uh oh!

mnajdova commented Jan 28, 2021

Uh oh!

natac13 commented Jan 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oliviertassinari Jan 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

natac13 Jan 28, 2021

Choose a reason for hiding this comment

Uh oh!

eps1lon Jan 28, 2021

Choose a reason for hiding this comment

Uh oh!

natac13 commented Jan 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

mui-pr-bot commented Jan 27, 2021 •

edited

Loading

natac13 commented Jan 28, 2021 •

edited

Loading

oliviertassinari Jan 28, 2021 •

edited

Loading