Skip to content

[Skeleton] Migrate to emotion#24652

Merged
oliviertassinari merged 19 commits intomui:nextfrom
kodai3:migrate/Skelton
Feb 11, 2021
Merged

[Skeleton] Migrate to emotion#24652
oliviertassinari merged 19 commits intomui:nextfrom
kodai3:migrate/Skelton

Conversation

@kodai3
Copy link
Contributor

@kodai3 kodai3 commented Jan 27, 2021

This PR migrates the Skelton component to the new emotion format as a part of #24405.

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 27, 2021

@material-ui/core: parsed: +0.27% , gzip: +0.33%
@material-ui/lab: parsed: +0.28% , gzip: +0.31%

Details of bundle changes

Generated by 🚫 dangerJS against 1f4c8e3

@oliviertassinari oliviertassinari changed the title [Skelton] migrate to emotion [Skeleton] Migrate to emotion Jan 27, 2021
@oliviertassinari oliviertassinari added the scope: skeleton Changes related to the skeleton. label Jan 27, 2021
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's convert the styles the css syntax, otherwise, styled-components won't work

@kodai3
Copy link
Contributor Author

kodai3 commented Feb 2, 2021

I have fixed where it was reviewed + α. Now running yarn test:unit locally passes but, ci/circleci: test_unit-1 fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: skeleton Changes related to the skeleton.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants