[Alert] Migrate AlertTitle to emotion#24448
Merged
Conversation
|
@material-ui/core: parsed: +0.08% , gzip: +0.08% |
mnajdova
reviewed
Jan 16, 2021
Contributor
Author
|
For now, I disabled the test but when @mnajdova will finish a task with which provides skipping some test, this component finished. Don't want to mix test issue with migration at this point. |
Member
Contributor
Author
|
Ok gonna do that later. |
Member
|
@povilass there are too many unrelated changes on the PR. Could you try to rebase again to latest next? |
Contributor
Author
|
Jesus smashing my head now because I am trying to rebase the wrong branch... xd @mnajdova |
mnajdova
reviewed
Jan 18, 2021
mnajdova
approved these changes
Jan 18, 2021
Member
mnajdova
left a comment
There was a problem hiding this comment.
Just one nit, looks good otherwise 👍 Thanks!
Contributor
Author
|
Nit done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One iteration of #24405