Merged
Conversation
|
@material-ui/lab: parsed: -0.11% 😍, gzip: +0.18% |
mnajdova
reviewed
Jan 16, 2021
Member
mnajdova
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Great progress, left some comments on things that should be fixed or can be improved. Let me know if you have more questions and we can update the migration guide to include some more info :)
Contributor
|
@mnajdova Probably it's [Alert] Migration to emotion |
Member
Right, thanks! The two PRs came approximately at the same time, so I must have confused them :) |
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
mnajdova
reviewed
Jan 17, 2021
mnajdova
reviewed
Jan 17, 2021
mnajdova
reviewed
Jan 18, 2021
mnajdova
approved these changes
Jan 18, 2021
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took a first stab at the Alert component for the emotion migration. One of #24405.
I have not yet figured out how to test and I would say generally a bit confused exactly how
overridesResolveranduseUtilityClassesworks but I'll be figuring that out the next few days. I'm opening this now 1) in case anyone wants to add some pointers 😅 and 2) so no one duplicates the work.