[docs] Document emotion migration breaking changes#24229
[docs] Document emotion migration breaking changes#24229oliviertassinari merged 4 commits intomui:nextfrom
Conversation
|
@luminaxster Which breaking change did you identify? |
|
@luminaxster I have tried to improve the changes to mention the breaking change coming from v5.0.0-alpha.17. Could you have a look to see if it matches your expectation? Thanks |
37c8845 to
8becf95
Compare
|
Cool to see that. But I have a question. Now the recommended order is |
@Jack-Works Yeah, you are right. We have a couple of visual regression tests in our codebase that is broken because of this (I believe). You could use |
|
It seems like this belongs in the migration guide even more-so than the change log. |
This is most relevant during the phase where the codebase still mix JSS and emotion. We have it in the migration guide: https://next.material-ui.com/guides/migration-v4/#styled-engine. |
Co-authored-by: Matt <github@nospam.33m.co>
|
I followed your changes @oliviertassinari, It works like a charm now. Since that was the first migrated component and I was not customizing it, I lazily skipped over the emotion details. Following on @mbrookes, indeed, what is missing is mentioning the guide when components are migrated, a compromise may be to add a note like this each time a component has been migrated to emotion: Thank you so much for your time and patience! =P. |
|
@luminaxster Thanks for the confirmation. Yeah, this migration period will be challenging to handle. The good news that it will only get better over time. |
Uh oh!
There was an error while loading. Please reload this page.