Skip to content

[Button] Remove inner span wrapper#24222

Closed
eps1lon wants to merge 1 commit intomui:nextfrom
eps1lon:fix/Button/remove-inner-span
Closed

[Button] Remove inner span wrapper#24222
eps1lon wants to merge 1 commit intomui:nextfrom
eps1lon:fix/Button/remove-inner-span

Conversation

@eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 2, 2021

Exploratory removal since the flexbox bug is now fixed in WebKit.

Right now it's not apparent if we even need this workaround with default styling. It seems to me this is only added in case people add display: flex and are not aware of the flexbox bug. So even if we still support browsers with this bug it might be interesting to revisit if it's worth fixing this bug if it only happens in some browsers with certain styles.

TODO:

  • check status of fix in opera and decide what to do if not fixed
  • Safari iOS vs Safari macOS (we support 10.? on iOS but 12.x on macOS)

@eps1lon eps1lon added performance breaking change Introduces changes that are not backward compatible. scope: button Changes related to the button. labels Jan 2, 2021
@eps1lon eps1lon added this to the v5 milestone Jan 2, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jan 2, 2021

Details of bundle changes

Generated by 🚫 dangerJS against fe890c7

@eps1lon
Copy link
Member Author

eps1lon commented Jan 2, 2021

Let's hope the builds a retained for a while so that I can work with the artifacts.

@eps1lon eps1lon closed this Jan 2, 2021
@eps1lon eps1lon deleted the fix/Button/remove-inner-span branch January 2, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Introduces changes that are not backward compatible. performance scope: button Changes related to the button.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants