Skip to content

[system] Remove visuallyHidden and move to /utils#23974

Merged
joshwooding merged 1 commit intomui:nextfrom
eps1lon:feat/utils/visuallyhidden
Dec 13, 2020
Merged

[system] Remove visuallyHidden and move to /utils#23974
joshwooding merged 1 commit intomui:nextfrom
eps1lon:feat/utils/visuallyhidden

Conversation

@eps1lon
Copy link
Member

@eps1lon eps1lon commented Dec 12, 2020

Breaking changes

  • [system] Move visually hidden helper to utils

    Only applies if you've installed v5.0.0-alpha.1

    -import { visuallyHidden } from '@material-ui/system';
    +import { visuallyHidden } from '@material-ui/utils';

Cherry-picked from #23902 so that we know what's going on.

I went ahead an removed it directly from the system. It was only added during this alpha which is the whole point of an alpha: iterate on the API.

Not adding this to the v5 milestone or else it'll be considered a breaking change from v4 to v5. It's only a breaking change between alphas.

@eps1lon eps1lon added breaking change Introduces changes that are not backward compatible. scope: system The system, the design tokens / styling foundations used across components. eg. @mui/system with MUI package: utils Specific to the utils package. labels Dec 12, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Dec 12, 2020

Details of bundle changes

Generated by 🚫 dangerJS against 6c02ebd

@eps1lon eps1lon marked this pull request as ready for review December 12, 2020 19:46
@joshwooding joshwooding merged commit bfbabfd into mui:next Dec 13, 2020
@eps1lon eps1lon deleted the feat/utils/visuallyhidden branch December 13, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Introduces changes that are not backward compatible. package: utils Specific to the utils package. scope: system The system, the design tokens / styling foundations used across components. eg. @mui/system with MUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants