[Icons] deprecate default value for fontSize in favor of medium#23951
[Icons] deprecate default value for fontSize in favor of medium#23951mbrookes wants to merge 4 commits intomui:masterfrom mbrookes:icons-fontsize-deprecation
default value for fontSize in favor of medium#23951Conversation
Details of bundle changes.Comparing: b0e10a1...d813865 Details of page changes
|
| * The fontSize applied to the icon. Defaults to 24px, but can be configure to inherit font size. | ||
| */ | ||
| fontSize?: 'inherit' | 'default' | 'small' | 'large'; | ||
| fontSize?: 'inherit' | 'large' | 'medium' | 'small'; |
There was a problem hiding this comment.
If this is a deprecation, shouldn't we have both default and medium to allow migration? Otherwise, we are breaking the build with this change.
|
Deprecations should be applied on the |
|
@mnajdova thanks. Where's the "quick, hide this PR so no-one notices the copy-pasta" button? |
|
@oliviertassinari "Deprecations should be applied on the v4-deprecations branch." I only have myself to blame for that. "It's simple" I said. 😆 |
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mui-org/material-ui/egqzfq3td |
|
Closing to change target branch |
Deprecation for #23950