[test] Run benchmarks in Azure Pipelines when approved#23895
Merged
[test] Run benchmarks in Azure Pipelines when approved#23895
Conversation
oliviertassinari
approved these changes
Dec 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that every member can update/inspect the results.
Example run: https://dev.azure.com/mui-org/Material-UI/_build/results?buildId=19952&view=results
How to run:
benchmarkforcommandwhy CircleCI is not viable
Might prevent dependabot from automatically merging. If that happens I'll try a different approach (e.g. webhooks, uncommenting lines in the CI config etc.)
Update: Yep, CircleCI approvals are not viable for github: https://ideas.circleci.com/cloud-feature-requests/p/show-overall-all-checks-have-passed-status-in-github-even-on-builds-with-incompl
Update2: I have no idea how to even look at the approved job. It immediately went green and the link for the job (from github) just points to the full pipeline: https://circleci.com/workflow-run/ab4615e9-b491-49d8-aaf5-5ea082c5a3ec?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-workflow-link