Skip to content

[system] Make borderRadius multiply a theme's design token#23700

Merged
mnajdova merged 13 commits intomui:nextfrom
mnajdova:feat/system-improve-border-radius
Nov 25, 2020
Merged

[system] Make borderRadius multiply a theme's design token#23700
mnajdova merged 13 commits intomui:nextfrom
mnajdova:feat/system-improve-border-radius

Conversation

@mnajdova
Copy link
Member

@mnajdova mnajdova commented Nov 24, 2020

Breaking changes

  • [system] The borderRadius system prop value transformation has been changed. It now expects number and multiplies this value with the theme.shape.borderRadius value.

    -<Box sx={{ borderRadius: 'borderRadius' }}>
    +<Box sx={{ borderRadius: 1 }}> // theme.shape.borderRadius * 1
    -<Box sx={{ borderRadius: 16 }}>
    +<Box sx={{ borderRadius: '16px' }}>

Closes #23188

@mui-pr-bot
Copy link

mui-pr-bot commented Nov 24, 2020

@material-ui/core: parsed: +0.06% , gzip: +0.11%
@material-ui/system: parsed: +3.04% , gzip: +2.29%

Details of bundle changes

Generated by 🚫 dangerJS against 96b67d1

@mnajdova mnajdova added breaking change Introduces changes that are not backward compatible. scope: system The system, the design tokens / styling foundations used across components. eg. @mui/system with MUI labels Nov 24, 2020
@oliviertassinari oliviertassinari changed the title [system] Change the borderRadius prop to use the theme.shape.borderRadius as a multiplication value [system] Change borderRadius to multiple the unit from the theme Nov 24, 2020
@oliviertassinari oliviertassinari changed the title [system] Change borderRadius to multiple the unit from the theme [system] Make borderRadius multiply a theme's design token Nov 24, 2020
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@mnajdova mnajdova merged commit 161fb85 into mui:next Nov 25, 2020
@oliviertassinari oliviertassinari added this to the v5-beta milestone Aug 17, 2021
@oliviertassinari oliviertassinari mentioned this pull request Aug 17, 2021
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Introduces changes that are not backward compatible. scope: system The system, the design tokens / styling foundations used across components. eg. @mui/system with MUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[system] Change the borderRadius prop to use the theme.shape.borderRadius as a multiplication value

4 participants