[Chip] Rename default variant to filled#22683
Merged
Conversation
mnajdova
commented
Sep 21, 2020
joshwooding
approved these changes
Sep 21, 2020
Member
I like that better. I don't really understand how I thought "standard" was better than "default" but IMO these are pretty synonymous. |
Member
Author
done :) |
joshwooding
approved these changes
Sep 21, 2020
joshwooding
reviewed
Sep 21, 2020
Collaborator
joshwooding
left a comment
There was a problem hiding this comment.
Looks good, I think there are references to the default variant on the docs page too so those will have to be changed as well :)
Member
Author
@joshwooding good catch! Fixed :) |
default variant to standarddefault variant to filled
mbrookes
approved these changes
Sep 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes
[Chip] Rename
defaultvariant tofilledfor consistency.Closes #18914
Part of #20012