Skip to content

[Menu] Remove transition onX props#22212

Merged
oliviertassinari merged 1 commit intomui:nextfrom
mbrookes:menu-remove-popover-onX
Aug 15, 2020
Merged

[Menu] Remove transition onX props#22212
oliviertassinari merged 1 commit intomui:nextfrom
mbrookes:menu-remove-popover-onX

Conversation

@mbrookes
Copy link
Member

@mbrookes mbrookes commented Aug 15, 2020

Menu

The onE* transition props were removed. Use TransitionProps instead.

<Menu
-  onEnter={onEnter}
-  onEntered={onEntered},
-  onEntering={onEntered},
-  onExit={onEntered},
-  onExited={onEntered},
-  onExiting={onEntered}
+  TransitionProps={{
+    onEnter,
+    onEntered,
+    onEntering,
+    onExit,
+    onExited,
+    onExiting,
+  }}
>

#17047 (comment)

@mbrookes mbrookes added breaking change Introduces changes that are not backward compatible. scope: menu Changes related to the menu. labels Aug 15, 2020
@mbrookes mbrookes added this to the v5 milestone Aug 15, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 15, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 785a68f

@mbrookes mbrookes mentioned this pull request Aug 15, 2020
Merged
@oliviertassinari oliviertassinari merged commit 83ed1cf into mui:next Aug 15, 2020
@mbrookes mbrookes deleted the menu-remove-popover-onX branch August 15, 2020 21:16
@oliviertassinari oliviertassinari mentioned this pull request Sep 15, 2020
Closed
42 tasks
@mbrookes mbrookes mentioned this pull request Sep 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

No one assigned

Labels

breaking change Introduces changes that are not backward compatible. scope: menu Changes related to the menu.

Projects

None yet

Milestone

v5.0.0-beta.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mbrookes @mui-pr-bot @oliviertassinari