Skip to content

[Popover] Remove transition onX props#22184

Merged
mbrookes merged 4 commits intomui:nextfrom
mbrookes:popover-remove-transition-onX-props
Aug 14, 2020
Merged

[Popover] Remove transition onX props#22184
mbrookes merged 4 commits intomui:nextfrom
mbrookes:popover-remove-transition-onX-props

Conversation

@mbrookes
Copy link
Member

@mbrookes mbrookes commented Aug 13, 2020 •
edited by oliviertassinari
Loading

Breaking change

The onE* transition props were removed. Use TransitionProps instead.

<Popover
-  onEnter={onEnter}
-  onEntered={onEntered},
-  onEntering={onEntered},
-  onExit={onEntered},
-  onExited={onEntered},
-  onExiting={onEntered}
+  TransitionProps={{
+    onEnter,
+    onEntered,
+    onEntering,
+    onExit,
+    onExited,
+    onExiting,
+  }}
/>

#17047 (comment)

@mbrookes mbrookes added breaking change Introduces changes that are not backward compatible. component: Popover The React component. labels Aug 13, 2020
@mbrookes mbrookes added this to the v5 milestone Aug 13, 2020
oliviertassinari
oliviertassinari approved these changes Aug 13, 2020
View reviewed changes
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 13, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against cba8298

@github-actions github-actions bot mentioned this pull request Aug 13, 2020
Closed
mbrookes and others added 3 commits August 13, 2020 20:39
@mbrookes @oliviertassinari
Update docs/src/pages/guides/migration-v4/migration-v4.md
80d5c0f 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@mbrookes
Fix tests
16b4c2e
@mbrookes
prettier
cba8298
@mbrookes mbrookes merged commit 183f267 into mui:next Aug 14, 2020
@mbrookes mbrookes deleted the popover-remove-transition-onX-props branch August 14, 2020 07:48
@mbrookes mbrookes mentioned this pull request Aug 14, 2020
Merged
@oliviertassinari oliviertassinari mentioned this pull request Sep 15, 2020
Closed
42 tasks
@mbrookes mbrookes mentioned this pull request Sep 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

No one assigned

Labels

breaking change Introduces changes that are not backward compatible. component: Popover The React component.

Projects

None yet

Milestone

v5.0.0-beta.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mbrookes @mui-pr-bot @oliviertassinari