Closed
Conversation
Details of bundle changes.Comparing: c776d34...878fca2 Details of page changes
|
oliviertassinari
requested changes
Mar 19, 2020
Member
oliviertassinari
left a comment
There was a problem hiding this comment.
Thanks for looking at the problem :). I have noticed that same issue with the "Default theme" tree view of the documentation. I think that we can take a step back and consider how we could change the implementation to make such demo easier to write.
| @@ -41,7 +41,7 @@ const useTreeItemStyles = makeStyles((theme: Theme) => | |||
| color: 'var(--tree-view-color)', | |||
| }, | |||
| '&:focus > $content $label, &:hover > $content $label, &$selected > $content $label': { | |||
Member
There was a problem hiding this comment.
I think that we should keep iterate on the CSS override story. A selector of this complexity isn't OK. It will require a breaking change on the component.
Collaborator
Author
There was a problem hiding this comment.
Could this pull be added to v5 milestone?
Member
There was a problem hiding this comment.
I don't think that we need to wait, TreeView won't make it to the core in v5.
Collaborator
Author
There was a problem hiding this comment.
Great. I'll will work on a proposal.
Collaborator
Author
|
@oliviertassinari What do you think about moving the |
Member
|
The usage of |
eps1lon
reviewed
Mar 25, 2020
Member
eps1lon
left a comment
There was a problem hiding this comment.
Would be nice to add explicit documentation for the variants. Right now I don't understand what the names of these variants mean.
Collaborator
Author
|
@eps1lon I changed my approach for one that doesn't require new props. |
1 task
1 task
Collaborator
|
@m4theushw Thanks for the help. We've taken a different approach to improve the override story. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20125