[core] Export TypographyVariant type#19598
Conversation
- export useful TS types for typography which were hard to discover - Remove unused code
|
No bundle size changes comparing 01b8b09...1ed5965 |
There was a problem hiding this comment.
Form how I understood it, the idea what to expose more variables from createMuiTheme, for instance, the ones we import deep in https://material-ui.com/guides/typescript/? I don't understand why the types of the Typography component needs to be changed.
| export interface TypographyTypeMap<P = {}, D extends React.ElementType = 'span'> { | ||
| props: P & { | ||
| align?: PropTypes.Alignment; | ||
| align?: TypographyAlignment; |
@oliviertassinari Ah i defiantly misunderstood that, but can do that if you would like. Would you want me to just import/export them straight from |
eps1lon
left a comment
There was a problem hiding this comment.
We were discussing Variant in createTypography not Typography. I can see no issue with Typography. Please stick to the things we discussed in the issue.
|
@aleccaputo Did you have the time to look at the issue? :) |
|
@oliviertassinari @eps1lon how's that look? |
|
@aleccaputo Thank you for the cooperation! |
for feature #19572
Closes #19572