Merged
Conversation
Details of bundle changes.Comparing: 2853239...965af81
|
eps1lon
reviewed
Jul 23, 2019
78fb526 to
b700c57
Compare
It has generted $1 to date, we won't get far.
Those were more proof of concept than anything else. I think that we should focus on having a few done very well than many.
Fix the warning in the console, follow the path suggested by vercel/next.js#8021.
Aria label is hard enough to add correctly, we don't want to have to worry about case.
b700c57 to
8794b87
Compare
8794b87 to
200bd12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would encourage the review of each commit, individually.