[List] Update to match the specification#15339
Merged
oliviertassinari merged 6 commits intomui:nextfrom Apr 15, 2019
Merged
Conversation
25c9e6c to
bc5b77d
Compare
|
@material-ui/core: parsed: -0.23% 😍, gzip: -0.16% 😍 Details of bundle changes.Comparing: 71d4ebe...af3b825
|
479b58e to
3992309
Compare
f143cc4 to
32e5846
Compare
1 task
eps1lon
reviewed
Apr 13, 2019
e23f166 to
14dc2be
Compare
2 tasks
Co-Authored-By: oliviertassinari <olivier.tassinari@gmail.com>
ee4567f to
4a9254f
Compare
56 tasks
2 tasks
Tomassito
reviewed
Jan 7, 2021
| root: { | ||
| flex: '1 1 auto', | ||
| minWidth: 0, | ||
| padding: '0 16px', |
There was a problem hiding this comment.
@oliviertassinari We are migrating v3 -> v4 and here and there paddings get removed breaking some layout
is there any particular reason why these changes were applied?
Do we know how many components undergone such style adjustments?
Member
Author
There was a problem hiding this comment.
I don't remember, nor I have the time to look at it. We encourage to have visual regression tests when upgrading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6098
Closes #14752 the padding is identical: 16px.
Breaking changes
Rework the list components to match the specification:
ListItemAvatarcomponent is required when using an avatarListItemIconcomponent is required when using a left checkboxedgeproperty should be set on the icon buttons.