[Dialog] Prepare deprecation of withMobileDialog#14992
Merged
oliviertassinari merged 1 commit intomui:masterfrom Jun 22, 2019
Merged
[Dialog] Prepare deprecation of withMobileDialog#14992oliviertassinari merged 1 commit intomui:masterfrom
oliviertassinari merged 1 commit intomui:masterfrom
Conversation
Details of bundle changes.Comparing: d1a7d76...e6e251b
|
382f483 to
e6e251b
Compare
56 tasks
e6e251b to
b683999
Compare
|
No bundle size changes comparing 6957c91...b683999 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare the deprecation of the
withMobileDialog()higher order component. The hook API allows a simpler and more flexible solution:The deprecation will happen in the next few months, to prepare v5. For now, I have only removed it from the demo. For people that can't use hooks, withWidth is still a viable alternative, we might provide a withMediaQuery hook in the future.