[docs] Update breakpoints.md for clarity#14527
Merged
oliviertassinari merged 2 commits intomui:nextfrom Feb 16, 2019
matthewjwhitney:patch-1
Merged
[docs] Update breakpoints.md for clarity#14527oliviertassinari merged 2 commits intomui:nextfrom matthewjwhitney:patch-1
oliviertassinari merged 2 commits intomui:nextfrom
matthewjwhitney:patch-1
Conversation
oliviertassinari
previously requested changes
Feb 14, 2019
| - **md**, medium: 960px or larger | ||
| - **lg**, large: 1280px or larger | ||
| - **xl**, extra-large: 1920px or larger | ||
| * **xs,** extra-small: 0px to 600px |
Member
There was a problem hiding this comment.
For consistency, I think that we should use - for marking a list item.
| ``` | ||
|
|
||
| ### `theme.breakpoints.between(start, end) => media query` | ||
| <a id="theme-breakpoints-between-start-end-media-query">### `theme.breakpoints.between(start, end) => media query`</a> |
Member
There was a problem hiding this comment.
What's wrong with the current hash generation logic?
| * **xs,** extra-small: 0px to 600px | ||
| * **sm,** small: 600px to 960px | ||
| * **md,** medium: 960px to 1280px | ||
| * **lg,** large: 1280px to 1920px |
Member
There was a problem hiding this comment.
This is not 💯 accurate. The actual value is 1920px - 0.05px, as the intervals have an empty intersection. It's important. But 0.05px is too low-level information. I think that it's it important for people to understand that a breakpoint has an associated range, inclusive. It's better explained in
https://material-ui.com/layout/hidden/#how-it-works. I'm not sure how we can explain it here.
As proposed in the discussion from issue #13448 [Breakpoints] functions down() and between() adds +1 to index, the breakpoint widths are described as a range. Furthermore, I found some broken hash links that I attempted to fix.
Member
|
@matthewjwhitney Thanks, I'm moving forward, I'm happy to take your feedback anytime you can :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As proposed in the discussion from issue #13448 [Breakpoints] functions down() and between() adds +1 to index, the breakpoint widths are described as a range. Furthermore, I found some broken hash links that I attempted to fix.
Closes #13448