Skip to content

[IconButton] Improve size values #24045

@ghost

Description

Current Behavior 😯

When giving IconButton size properties medium and larger the size class is not set.

Screenshot 2020-12-18 at 15 02 30

Expected Behavior 🤔

That MuiIconButton get MuiIconButton-sizeMedium and MuiIconButton-sizeLarge the same way as MuiIconButton-sizeSmall

Steps to Reproduce 🕹

<IconButton size="large">
  <FontAwesomeIcon icon={faPlay} />
  <FontAwesomeIcon icon={faChevronRight} />
</IconButton>
<IconButton size="medium">
  <FontAwesomeIcon icon={faPlay} />
  <FontAwesomeIcon icon={faChevronRight} />
</IconButton>

Your Environment 🌎

`System: OS: macOS 11.0.1 Binaries: Node: 12.18.4 - /usr/local/bin/node Yarn: 1.22.5 - ~/.yarn/bin/yarn npm: 6.14.9 - /usr/local/bin/npm Browsers: Chrome: 87.0.4280.88 * Edge: Not Found * Firefox: Not Found Safari: 14.0.1 npmPackages: @emotion/styled: 10.0.27 @material-ui/core: ^4.11.2 => 4.11.2 @material-ui/styles: 4.11.2 @material-ui/system: 4.11.2 @material-ui/types: 5.1.0 @material-ui/utils: 4.11.2 @types/react: ^16.9.53 => 16.14.2 react: ^17.0.1 => 17.0.1 react-dom: ^17.0.1 => 17.0.1 styled-components: ^5.2.1 => 5.2.1 typescript: ^4.0.3 => 4.1.3 `

Metadata

Metadata

Assignees

No one assigned

    Labels

    breaking changeIntroduces changes that are not backward compatible.design: materialThis is about Material Design, please involve a visual or UX designer in the processready to takeHelp wanted. Guidance available. There is a high chance the change will be acceptedscope: icon buttonChanges related to the icon button.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions