Skip to content

[Menu] CheckboxItem component#533

Merged
michaldudak merged 17 commits intomui:masterfrom
michaldudak:menu-checkboxitem
Sep 19, 2024
Merged

[Menu] CheckboxItem component#533
michaldudak merged 17 commits intomui:masterfrom
michaldudak:menu-checkboxitem

Conversation

@michaldudak
Copy link
Member

@michaldudak michaldudak commented Aug 5, 2024

Created the MenuCheckboxItem component.

Closes #52

@michaldudak michaldudak added component: menu Changes related to the menu component. type: new feature Expand the scope of the product to solve a new problem. labels Aug 5, 2024
@mui-bot
Copy link

mui-bot commented Aug 5, 2024

Netlify deploy preview

https://deploy-preview-533--base-ui.netlify.app/

Generated by 🚫 dangerJS against 88b43f0

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 5, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 9, 2024
@colmtuite colmtuite requested a review from vladmoroz September 9, 2024 08:54
@michaldudak michaldudak marked this pull request as ready for review September 9, 2024 09:37
@colmtuite
Copy link
Contributor

@michaldudak Same feedback as radio item.

I was surprised that the Menu doesn't close when you select a radio item using Enter. Radix closes the menu whether you select a radio/checkbox item via click, space, or Enter. RA closes on Enter only. Do you think we should keep the Menu open always? Or close when you select a radio item using Enter?

@michaldudak michaldudak merged commit 6127e9d into mui:master Sep 19, 2024
@michaldudak michaldudak deleted the menu-checkboxitem branch September 19, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: menu Changes related to the menu component. type: new feature Expand the scope of the product to solve a new problem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[menu] Create the checkbox menu item

4 participants