[Menu] Overhaul the component API#468
Merged
michaldudak merged 122 commits intomui:masterfrom Aug 2, 2024
Merged
Conversation
Contributor
|
Bug when traversing back to the submenu trigger, menu doesn't open Screen.Recording.2024-07-25.at.11.33.36.PM.mov |
Contributor
|
@michaldudak Feedback based on our chat:
|
Member
Author
|
@colmtuite I did 1 and 2. |
Contributor
|
@michaldudak In this vid, the menu is initially opening above the trigger, then quickly repositioning itself below. |
Member
Author
@atomiks, Should be working OK now.
@colmtuite, could you prepare a reproduction on codesandbox? |
colmtuite
approved these changes
Aug 1, 2024
14 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #214
Closes #9
Closes #46
Closes #63
Closes #411
Preview
https://deploy-preview-468--base-ui.netlify.app/base-ui/react-menu/
To do
transitionDurationCSS property is used #9keepMountedpropIn separate PRs