Skip to content

[core] Use basic scroll lock on iOS#1890

Merged
atomiks merged 5 commits intomui:masterfrom
atomiks:remove-ios-lock
May 8, 2025
Merged

[core] Use basic scroll lock on iOS#1890
atomiks merged 5 commits intomui:masterfrom
atomiks:remove-ios-lock

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented May 8, 2025

Until we find a solution that works without any (dealbreaker) side effects, it's best if this is simply disabled on iOS.

Closes #1888

@atomiks atomiks requested a review from colmtuite as a code owner May 8, 2025 10:09
@atomiks atomiks added the core label May 8, 2025
@atomiks atomiks requested a review from michaldudak as a code owner May 8, 2025 10:09
@atomiks atomiks force-pushed the remove-ios-lock branch from 28b6a25 to 85c8c0e Compare May 8, 2025 10:12
@atomiks atomiks force-pushed the remove-ios-lock branch from 85c8c0e to 13748f5 Compare May 8, 2025 10:12
@pkg-pr-new
Copy link

pkg-pr-new bot commented May 8, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@base-ui-components/react@1890

commit: a287386

@netlify
Copy link

netlify bot commented May 8, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 85c8c0e
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/681c83791885630007a95927
😎 Deploy Preview https://deploy-preview-1890--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented May 8, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit a287386
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/681c8b4045cbc70008371728
😎 Deploy Preview https://deploy-preview-1890--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@atomiks
Copy link
Contributor Author

atomiks commented May 8, 2025

overflow: hidden on iOS does work if the navbar is expanded at least

@atomiks atomiks changed the title [core] Remove scroll lock on iOS [core] Use basic scroll lock on iOS May 8, 2025
@atomiks atomiks merged commit a430162 into mui:master May 8, 2025
22 checks passed
@atomiks atomiks deleted the remove-ios-lock branch May 8, 2025 10:51
@michaldudak michaldudak added component: select Changes related to the select component. component: menu Changes related to the menu component. component: alert dialog Changes related to the alert dialog component. component: dialog Changes related to the dialog component. breaking change Introduces changes that are not backward compatible. component: popover Changes related to the popover component. mobile Targets mobile platform. and removed core labels May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Introduces changes that are not backward compatible. component: alert dialog Changes related to the alert dialog component. component: dialog Changes related to the dialog component. component: menu Changes related to the menu component. component: popover Changes related to the popover component. component: select Changes related to the select component. mobile Targets mobile platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[dialog][iOS Safari] Background scrolls to top of page when focusing a textarea within a dialog

2 participants