[separator] Support vertical orientation#1304
Merged
mj12albert merged 3 commits intomui:masterfrom Jan 8, 2025
Merged
Conversation
Netlify deploy preview |
64fcc31 to
ad24d62
Compare
mj12albert
commented
Jan 8, 2025
| </a> | ||
|
|
||
| <Separator className={styles.Separator} /> | ||
| <Separator orientation="vertical" className={styles.Separator} /> |
Member
Author
There was a problem hiding this comment.
These are actually vertical but incorrectly defaulted to horizontal before
ad24d62 to
8334bd0
Compare
8334bd0 to
e1132e3
Compare
atomiks
approved these changes
Jan 8, 2025
Contributor
atomiks
left a comment
There was a problem hiding this comment.
"The orientation of the separator" might work better than "The component orientation."?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1303
Prerequisite for Toolbar #661