Skip to content

New build image#37

Merged
muhamadto merged 6 commits intomainfrom
new_image
May 7, 2023
Merged

New build image#37
muhamadto merged 6 commits intomainfrom
new_image

Conversation

@muhamadto
Copy link
Copy Markdown
Owner

Hello, Please Review My Pull Request!

✔️ Checklist

  • Describe what you did in the pull request description
  • Add Unit and Integration Tests - at least 80% unit tests for new code.
  • Added or updated documentation

@muhamadto muhamadto force-pushed the new_image branch 3 times, most recently from 72867a6 to 94ec919 Compare May 7, 2023 12:48
"SNS:GetTopicAttributes",
"SNS:ListSubscriptionsByTopic",
"SNS:Unsubscribe"
"SNS:Unsubscribe",
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS now requires these new permissions


final Queue successQueue = createFifoQueue(SQS_SUCCESS_QUEUE_ID, true, MESSAGE_GROUP);
final SqsSubscription successQueueSubscription = createSqsSubscription(successQueue);
final Topic successTopic = createFifoTopic(SNS_SUCCESS_TOPIC_ID, true, true);
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS does not allow fifo topics as lambda destination anymore (or at least fail when provided with fifo as destination for lambda)

@muhamadto muhamadto force-pushed the new_image branch 4 times, most recently from 7a4b3b0 to 389607c Compare May 7, 2023 13:24
@muhamadto muhamadto merged commit c6d18c5 into main May 7, 2023
@muhamadto muhamadto deleted the new_image branch May 7, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant