Conversation
72867a6 to
94ec919
Compare
muhamadto
commented
May 7, 2023
| "SNS:GetTopicAttributes", | ||
| "SNS:ListSubscriptionsByTopic", | ||
| "SNS:Unsubscribe" | ||
| "SNS:Unsubscribe", |
Owner
Author
There was a problem hiding this comment.
AWS now requires these new permissions
muhamadto
commented
May 7, 2023
|
|
||
| final Queue successQueue = createFifoQueue(SQS_SUCCESS_QUEUE_ID, true, MESSAGE_GROUP); | ||
| final SqsSubscription successQueueSubscription = createSqsSubscription(successQueue); | ||
| final Topic successTopic = createFifoTopic(SNS_SUCCESS_TOPIC_ID, true, true); |
Owner
Author
There was a problem hiding this comment.
AWS does not allow fifo topics as lambda destination anymore (or at least fail when provided with fifo as destination for lambda)
7a4b3b0 to
389607c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, Please Review My Pull Request!
✔️ Checklist