Skip to content

handle no clipboard more gracefully, prints to stdout#30

Merged
mufeedvh merged 1 commit intomufeedvh:mainfrom
perstarkse:gracefully-no-clipboard
Aug 6, 2024
Merged

handle no clipboard more gracefully, prints to stdout#30
mufeedvh merged 1 commit intomufeedvh:mainfrom
perstarkse:gracefully-no-clipboard

Conversation

@perstarkse
Copy link
Copy Markdown
Contributor

Small change to handle no clipboard error without panicking, will print to sdtout if no clipboard. Will close #26

Seems like some minor formatting changes got included as well due to auto-formatter, let me know if that's a issue.

@HmmIsThisThingOn
Copy link
Copy Markdown

This fixed the the clipboard panic error for me, but the exclude function isn't working as intended with globs, listing many filetypes

@perstarkse
Copy link
Copy Markdown
Contributor Author

perstarkse commented Jul 8, 2024

This fixed the the clipboard panic error for me, but the exclude function isn't working as intended with globs, listing many filetypes

And the exclude function works as normal when not using this commit? I see there’s a reported issue about the exclude functionality. #31

@HmmIsThisThingOn
Copy link
Copy Markdown

The other commit didn't work for me, but yeah, probably not your issue :) Sorry, I'm by all measures unqualified to have a github account

@perstarkse
Copy link
Copy Markdown
Contributor Author

The other commit didn't work for me, but yeah, probably not your issue :) Sorry, I'm by all measures unqualified to have a github account

No worries at all, reporting bugs and testing are large parts to making open source software great!
Looking at the code affected by this commit I suspect that the bug isn’t introduced here, but sometimes unexpected things happen :)

@mufeedvh
Copy link
Copy Markdown
Owner

mufeedvh commented Aug 6, 2024

Thank you so much @perstarkse for the PR! Merging now! ❤️ 🙌

@mufeedvh mufeedvh merged commit 4e5cdf7 into mufeedvh:main Aug 6, 2024
@perstarkse perstarkse deleted the gracefully-no-clipboard branch August 7, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panics if clipboard copying is not available

3 participants