Use file interface instead of requiring os.File#2
Merged
muesli merged 1 commit intomuesli:mainfrom Feb 10, 2022
Merged
Conversation
Owner
|
Probably makes sense. Curious, what types / implementations of this interface are you referring to? |
muesli
requested changes
Feb 10, 2022
e907927 to
31416e3
Compare
Contributor
Author
|
For example containerd's |
muesli
requested changes
Feb 10, 2022
muesli
reviewed
Feb 10, 2022
muesli
reviewed
Feb 10, 2022
muesli
reviewed
Feb 10, 2022
Signed-off-by: Edgar Lee <edgarl@netflix.com>
muesli
approved these changes
Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have some downstreams that won't be able to provide
os.Filebut something close to it.