Don't hardcode the version #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add a `version` command that only prints the version (without the build time) Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
commented
Mar 21, 2024
| - CGO_ENABLED=0 | ||
| ldflags: | ||
| - -s -w | ||
| - -X "github.com/mudler/luet/cmd.Version={{ .Summary }}" |
Contributor
Author
There was a problem hiding this comment.
jimmykarily
commented
Mar 21, 2024
| # go tool nm ./luet | grep Commit | ||
| override LDFLAGS += -X "github.com/mudler/luet/cmd.BuildTime=$(shell date -u '+%Y-%m-%d %I:%M:%S %Z')" | ||
| override LDFLAGS += -X "github.com/mudler/luet/cmd.BuildCommit=$(shell git rev-parse HEAD)" | ||
| override LDFLAGS += -X "github.com/mudler/luet/cmd.Version=$(shell git describe --dirty --always --tags)" |
Contributor
Author
There was a problem hiding this comment.
same as .Summary above (see link)
jimmykarily
commented
Mar 21, 2024
| Use: "version", | ||
| Short: "Print the version of luet", | ||
| Run: func(cmd *cobra.Command, args []string) { | ||
| fmt.Println(Version) |
Contributor
Author
There was a problem hiding this comment.
~/workspace/kairos/luet (fix-version)$ ./luet version
0.35.1-dirty
~/workspace/kairos/luet (fix-version)$ ./luet -v
luet version 0.35.1-dirty (Build time: 2024-03-21 08:05:33 UTC)
jimmykarily
commented
Mar 21, 2024
| import "github.com/mudler/luet/cmd" | ||
|
|
||
| var ( | ||
| version string |
Contributor
Author
There was a problem hiding this comment.
wasn't used anywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add a
versioncommand that only prints the version (without the build time)Fixes: kairos-io/kairos#2370