fix(chat): use proper finish_reason for tool/function calling #6243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Mário Freitas <imkira@gmail.com>
30921d7 to
174207a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #6218
The issue is not mine but I ran into the same issue when using LocalAI as an OpenAI-compatible endpoint in another tool. The tool saw the
finish_reasonin the response astool_callsand it assumed there had to be atool_callsarray in themessage, which was not the case and causing it to crash. It turns out the problem was because we are incorrectly setting thefinish_reasontype astool_calls(orfunction_call) when there is no tool/function involved.Notes for Reviewers
Signed commits