Skip to content

feat: add --rotate-on-error & --max-errors options#249

Merged
dwisiswant0 merged 5 commits intomasterfrom
dwisiswant0/feat/rotate-on-error
Sep 7, 2024
Merged

feat: add --rotate-on-error & --max-errors options#249
dwisiswant0 merged 5 commits intomasterfrom
dwisiswant0/feat/rotate-on-error

Conversation

@dwisiswant0
Copy link
Copy Markdown
Collaborator

@dwisiswant0 dwisiswant0 commented Sep 7, 2024

IMPORTANT: Please do not create a Pull Request without creating an issue first!

(Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request).

Summary

Adds

  • --rotate-on-error option.
  • --max-errors option.

Proposed of changes

This PR fixes/implements the following bugs/features:

How has this been tested?

Proof:

Closing issues

Fixes #244

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have followed the guidelines in our CONTRIBUTING.md document.
  • I have written new tests for my changes.
  • My changes successfully ran and pass tests locally.

Signed-off-by: Dwi Siswanto <git@dw1.io>
Signed-off-by: Dwi Siswanto <git@dw1.io>
Signed-off-by: Dwi Siswanto <git@dw1.io>
Signed-off-by: Dwi Siswanto <git@dw1.io>
Signed-off-by: Dwi Siswanto <git@dw1.io>
@dwisiswant0 dwisiswant0 merged commit 82ae8ac into master Sep 7, 2024
@dwisiswant0 dwisiswant0 deleted the dwisiswant0/feat/rotate-on-error branch September 7, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Rotate on retry

1 participant