refactor(proxymanager): handle Proxies index

dwisiswant0 · dwisiswant0 · commit fd8db549dfb8 · 2024-09-15T11:39:06.000+07:00
Signed-off-by: Dwi Siswanto &lt;git@dw1.io&gt;
diff --git a/internal/proxymanager/utils.go b/internal/proxymanager/utils.go
@@ -5,6 +5,7 @@ import (
 	"math/rand"
 
 	"github.com/fsnotify/fsnotify"
+	"github.com/kitabisa/mubeng/common/errors"
 	"github.com/kitabisa/mubeng/pkg/helper"
 )
 
@@ -16,20 +17,36 @@ func (p *ProxyManager) Count() int {
 }
 
 // NextProxy will navigate the next proxy to use
-func (p *ProxyManager) NextProxy() string {
+func (p *ProxyManager) NextProxy() (string, error) {
+	var proxy string
+
+	count := p.Count()
+	if count <= 0 {
+		return proxy, errors.ErrNoProxyLeft
+	}
+
 	p.CurrentIndex++
-	if p.CurrentIndex > p.Count()-1 {
+	if p.CurrentIndex > count-1 {
 		p.CurrentIndex = 0
 	}
 
-	proxy := p.Proxies[p.CurrentIndex]
+	proxy = p.Proxies[p.CurrentIndex]
 
-	return proxy
+	return proxy, nil
 }
 
 // RandomProxy will choose a proxy randomly from the list
-func (p *ProxyManager) RandomProxy() string {
-	return p.Proxies[rand.Intn(p.Count())]
+func (p *ProxyManager) RandomProxy() (string, error) {
+	var proxy string
+
+	count := p.Count()
+	if count <= 0 {
+		return proxy, errors.ErrNoProxyLeft
+	}
+
+	proxy = p.Proxies[rand.Intn(count)]
+
+	return proxy, nil
 }
 
 // RemoveProxy removes target proxy from proxy pool
@@ -48,21 +65,22 @@ func (p *ProxyManager) RemoveProxy(target string) error {
 // Rotate proxy based on method
 //
 // Valid methods are "sequent" and "random", default return empty string.
-func (p *ProxyManager) Rotate(method string) string {
+func (p *ProxyManager) Rotate(method string) (string, error) {
 	var proxy string
+	var err error
 
 	switch method {
 	case "sequent":
-		proxy = p.NextProxy()
+		proxy, err = p.NextProxy()
 	case "random":
-		proxy = p.RandomProxy()
+		proxy, err = p.RandomProxy()
 	}
 
 	if proxy != "" {
 		proxy = helper.EvalFunc(proxy)
 	}
 
-	return proxy
+	return proxy, err
 }
 
 // Watch proxy file from events
