setup: add image-gen boolean input to conditionally install image tools#4
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/mtransitapps/gh-actions/sessions/82388b7e-ebb8-4051-846d-10ebf77e361d Co-authored-by: mmathieum <177998+mmathieum@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for image-gen boolean input in setup action
setup: add Apr 15, 2026
image-gen boolean input to conditionally install image tools
mmathieum
reviewed
Apr 15, 2026
Member
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces an image-gen input to the setup action, allowing for conditional installation of image-related dependencies (inkscape and imagemagick). The feedback suggests adding sudo apt-get update to the new installation step for better reliability and simplifying the environment variable assignment by leveraging the boolean nature of the input.
mmathieum
reviewed
Apr 15, 2026
…S to code setup step Agent-Logs-Url: https://github.com/mtransitapps/gh-actions/sessions/22614c4e-de3b-4cb3-8484-d7371b17e136 Co-authored-by: mmathieum <177998+mmathieum@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
image-genboolean input to conditionally install image toolssudo apt-get updatebeforeapt-get installin the image dependencies step for consistency and robustnessMT set MT_GENERATE_IMAGES envstep; moveMT_GENERATE_IMAGESas a step-levelenvonMT code setuponly