Skip to content

TimeZone != TimeZoneId#124

Merged
mmathieum merged 1 commit into
masterfrom
copilot/fix-real-time-image-display
Apr 22, 2026
Merged

TimeZone != TimeZoneId#124
mmathieum merged 1 commit into
masterfrom
copilot/fix-real-time-image-display

Conversation

@mmathieum

Copy link
Copy Markdown
Member

No description provided.

@mmathieum mmathieum self-assigned this Apr 22, 2026
@mmathieum mmathieum marked this pull request as ready for review April 22, 2026 18:10

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames various time zone-related methods and constants to include an "Id" suffix for better clarity across multiple provider and utility classes. It also removes an unused formatTime method in TimeUtils. Feedback was provided regarding breaking changes caused by renaming public methods in Schedule.java and AgencyUtils.kt. It is recommended to retain the original method names as deprecated aliases to maintain backward compatibility and to ensure that new methods are not incorrectly marked as deprecated.

Comment thread src/main/java/org/mtransit/android/commons/data/Schedule.java
@mmathieum mmathieum merged commit d988e7f into master Apr 22, 2026
@mmathieum mmathieum deleted the copilot/fix-real-time-image-display branch April 22, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant