Module Store listing gen > add config/agency_type#652
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces logic across several shell scripts to dynamically update the TYPE_LABEL variable by reading from an optional agency_type configuration file. The review feedback consistently points out opportunities to improve the implementation by using standard 2-space indentation, removing unnecessary log noise when optional files are missing, and ensuring file path variables are properly quoted to handle potential spaces.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for a new config/agency_type override to customize the “type” label (e.g., Bus/Train/Bike) used across generated README content, GitHub repo metadata, Android string resources, and Play Store listing text/graphics scripts.
Changes:
- Read optional
config/agency_typeand use it to overrideTYPE_LABELin multiple generators. - Update GitHub repo description generation to incorporate the overridden type label.
- Minor whitespace cleanup in several listing/graphic generation scripts (
elseformatting).
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| shared-modules/MTREADME.md.MT.sh | Adds agency_type override to affect generated README header/type label. |
| shared-modules/gh_repo_update_details.sh | Adds agency_type override to affect generated GitHub repo description. |
| shared-modules/app-android/src/main/res/values/MTstrings.xml.MT.sh | Adds agency_type override for generated Android string resources. |
| shared-modules/app-android/src/main/res/values/MTgtfs_rts_strings.xml.MT.sh | Adds agency_type override for GTFS-RTS strings resource generation. |
| shared-modules/app-android/src/main/play/listings/fr-FR/MTfull-description.txt.MT.sh | Whitespace cleanup in conditional branches. |
| shared-modules/app-android/src/main/play/listings/en-US/MTtitle.txt.MT.sh | Adds agency_type override to affect Play listing title generation. |
| shared-modules/app-android/src/main/play/listings/en-US/MTshort-description.txt.MT.sh | Adds agency_type override to affect Play listing short description generation. |
| shared-modules/app-android/src/main/play/listings/en-US/MTfull-description.txt.MT.sh | Adds agency_type override to affect Play listing full description generation + whitespace cleanup. |
| shared-modules/app-android/src/main/play/listings/en-US/graphics/feature-graphic/MT1.png.MT.sh | Whitespace cleanup in conditional branches. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
config/agency_type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.