Skip to content

fix: replace native tail with fs-tail-stream#175

Closed
mojoaxel wants to merge 2 commits intomthenw:masterfrom
mojoaxel:windowsSupport
Closed

fix: replace native tail with fs-tail-stream#175
mojoaxel wants to merge 2 commits intomthenw:masterfrom
mojoaxel:windowsSupport

Conversation

@mojoaxel
Copy link
Copy Markdown
Contributor

@mojoaxel mojoaxel commented Aug 3, 2019

fixes #111 (windows support)

@mojoaxel mojoaxel mentioned this pull request Aug 3, 2019
Closed
@mthenw
Copy link
Copy Markdown
Owner

mthenw commented Aug 6, 2019

Wow, thanks for that PR. I will review it later today!

mthenw
mthenw reviewed Aug 6, 2019
View reviewed changes
@mthenw
Copy link
Copy Markdown
Owner

mthenw commented Aug 6, 2019

Also, do you know if fs-tail-stream supports log rotation?

@mojoaxel
Copy link
Copy Markdown
Contributor Author

mojoaxel commented Aug 6, 2019

Also, do you know if fs-tail-stream supports log rotation?

I don't think so 😢
This probably kills this PR

@mojoaxel
Copy link
Copy Markdown
Contributor Author

mojoaxel commented Aug 6, 2019

Log-rotation is a problem! I tested it and the results are not pretty.
I don't think adding windows support in favor of log-rotation makes sense. 😞

Maybe I find another way to fix #111.

@mojoaxel mojoaxel closed this Aug 6, 2019
@mojoaxel mojoaxel mentioned this pull request Jan 31, 2020
Closed
@mojoaxel
Copy link
Copy Markdown
Contributor Author

mojoaxel commented Jan 31, 2020

@mthenw Could you please reopen this PR!

I've updated my branch to make the windows support additional to the existing tail support!
This way the existing functionality does not change and the windows support is just a fallback for systems without the tail command. Windows support is still missing support for log rotation.

I think a lot of people would like to use frontail on windows even without log-rotation support!

@mthenw
Copy link
Copy Markdown
Owner

mthenw commented Feb 2, 2020

I'm not able to open this PR. Can you open a new one?

@mojoaxel mojoaxel mentioned this pull request Feb 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mthenw mthenw mthenw left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows support

2 participants

@mojoaxel @mthenw